Spd save as xml#954
Merged
jginternational merged 19 commits intomasterfrom Oct 9, 2023
Merged
Conversation
This reverts commit f846eac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPD files are the xml files that define the tree structure. For a given case, we store the properties tree in case.spd which is a compressed xml file.
With this PR, this file will remain uncompressed.
Basic users will be able to open and edit it, for example, to change a value.
For example, set the Inlet to 5 m/s
Advanced users will be able to edit it in a batch loop, for example in a python or shell script, create copies of this file, and changing the Inlet of each of this cases.
Developers will be able to open the spd file in order to implement better the writing scripts
Users that needed this features used to change the parameters in the ProjectParameters.json, which was a good way of doin it, but if you load the GiD model and write the input files again, you lost your changes. with this method, the changes remain with the model.