Gate literature_search by worker web-search capability#5
Open
idrassi wants to merge 1 commit intoKripner:masterfrom
Open
Gate literature_search by worker web-search capability#5idrassi wants to merge 1 commit intoKripner:masterfrom
idrassi wants to merge 1 commit intoKripner:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4.
Summary
This PR fixes a mixed-backend correctness issue in
literature_search.Previously,
--no-isolationwas effectively gated by the planner model, but the actual search is executed by the worker backend. That meant configurations such as:could expose
literature_searchto the planner even though the worker could not actually perform web search.What changed
Validation
Tested with:
python3 -m py_compile openprover/model_caps.py openprover/cli.py openprover/prover.py openprover/llm/claude.py openprover/llm/hf.py tests/test_model_caps.py tests/test_cli_validation.pypython3 -m pytest tests/test_model_caps.py tests/test_cli_validation.pyAlso verified that the previously broken mixed-backend case now fails fast with a clear error:
python3 -m openprover --theorem examples/cauchy_schwarz.md --planner-model opus --worker-model minimax-m2.5 --no-isolation --headless --max-time 1s