Make install.sh more flexible #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int_error" functions
…more conditional; add guard rails around cloning of the github repo; allow customization of install directory using PREFIX environment variable
Owner
|
thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates install script to only install dependencies that are missing (addressing #13). In addition, there are additional checks around building to prevent redundant downloads of the repository and/or failures on mac systems with repeat builds/installations (addressing #14).
There are also minor enhancements to allow installation in a separate directory (using the
PREFIXenvironment variable), updating theprint_statusandprint_errorfunctions so they don't require quoting of arguments, etc.CAVEAT: Testing was primarily done on a mac system. Minimal additional testing was performed on a RHEL 8.x system. I do not have the additional hardware/VMs available to test on the alternate systems.