Skip to content

Fix for Blazor.Streams latest version (0.4.2)#7

Closed
jlchavez wants to merge 2 commits intoKristofferStrube:mainfrom
jlchavez:main
Closed

Fix for Blazor.Streams latest version (0.4.2)#7
jlchavez wants to merge 2 commits intoKristofferStrube:mainfrom
jlchavez:main

Conversation

@jlchavez
Copy link
Copy Markdown

Fix to work with the latest version of Blazor.Streams (0.4.2) WritableStream base class.

Missing a CreationOptions parameter for WritableStream constuctor.

Fix to work with the latest version of Blazor.Streams (0.4.2) WritableStream base class.
@jlchavez jlchavez changed the title Fix for Blazor.Streams latest Fix for Blazor.Streams latest version (0.4.2) Jun 24, 2024
@KristofferStrube
Copy link
Copy Markdown
Owner

Hey @jlchavez thanks for the PR. I planned to make an upgrade to have CreationOptions for all JS wrapper types in Blazor.FileAPI first and then do the same for this project followed by Blazor.FileSystemAccess. And while doing this also upgrade to use the newest version of Blazor.WebIDL in all the projects. Sorry that this was not clear from any issues or documentation.

If you need to use the newest version of Blazor.Streams then I can prioritize getting this done quickly so that you can proceed.

@jlchavez
Copy link
Copy Markdown
Author

Thanks, I had to recompile FileSystem and FileApi, because of fixing Streams, but compilation failed because of WebIDL so had to pull all projects and recompile including DOM. Currently working with my forks, and when there is an update I'll update everything to using nuget.

@KristofferStrube
Copy link
Copy Markdown
Owner

Hey @jlchavez, I have made this update myself as part of some general maintenance in #10 . It is currently released to NuGet as an alpha, but I will make a normal release soon, once I have updated Blazor.FileSystemAccess as well. Would you be able to test if this alpha works for your project, so that I can correct any errors before making the normal release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants