Compatibilty (windows, python versions)#302
Merged
Merged
Conversation
--HG-- branch : compat_win
--HG-- branch : compat_win
--HG-- branch : compat_win
--HG-- branch : compat_win
(had line break issues on win32)
Scss module does not need to be imported to load the variables from scss.scss_meta
Collaborator
|
good stuff, thanks! (hopefully |
eevee
added a commit
that referenced
this pull request
Aug 26, 2014
Compatibilty (windows, python versions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
Having started with a compat_win branch for windows compatibility (especially about
os.sep), I've extended its scope and added a tox file for automated testing across environments (feel free to drop the tox file if you don't want it, I simply find it handy to generate virtual environments).Btw, half of the commits here are already included in the import_sprite branch (PR #284).
Main comments:
unixinput file path was translated into awindowsone, and that every URL was generated with forward slashes onlycodecsbyioto importopenon python 2 (codecscauses issues with linebreaks)enum34package when using python < 3.4scss_meta.pyin setup.py, so there is no need to install six locally asscss/__init__.pyis not imported anymorewithstatement inscss/functions/fonts.py, which I replaced by 2 nestedwithstatements. It may also be considered to drop support for py26Observations:
image/x-pnginstead ofimage/png. Didn't dig into that, can live with it