feat: Simple Kubernetes TokenReview identity object#403
Merged
guicassolato merged 1 commit intomainfrom Jun 12, 2023
Merged
Conversation
Makes the Kubernetes TokenReview-based identity method to always fill the identity object from the [status](https://kubernetes.io/docs/reference/kubernetes-api/authentication-resources/token-review-v1/#TokenReviewStatus) of the TokenReview response, as opposed to the current hybrid behaviour of trying to detect whether the verified access token is a JWT or an opaque token.
eguzki
approved these changes
Jun 8, 2023
Collaborator
eguzki
left a comment
There was a problem hiding this comment.
verification steps working
didierofrivia
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Kubernetes TokenReview-based identity method to always fill the identity object from the status field of the TokenReview response, as opposed to the current hybrid behaviour of trying to detect whether the verified access token is a JWT or an opaque token.
Closes #394.
Warning! This is a breaking change and users of Authorino Kubernetes identity verification method must consider its impact to existing AuthConfigs before upgrading to a new version.
Users relying on JWT detection can still extract, decode and parse the JWT directly from the Authorization header. Here’s an example extending the identity object*:
* Requires #401.
Verification steps
① Deploy
② Follow the steps of the Authentication with Kubernetes tokens (TokenReview API) user guide from step 5