chore(log): improve panic message for invalid log mode#571
Merged
KevFan merged 1 commit intoKuadrant:mainfrom Feb 4, 2026
Merged
chore(log): improve panic message for invalid log mode#571KevFan merged 1 commit intoKuadrant:mainfrom
KevFan merged 1 commit intoKuadrant:mainfrom
Conversation
Provides actionable feedback when an unknown log mode is specified by showing both the invalid value and the list of valid options. This helps users quickly identify and correct configuration errors instead of e.g. finding which values are acceptable in the docs. Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
KevFan
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides actionable feedback when an unknown log mode is specified by showing both the invalid value and the list of valid options.
This helps users quickly identify and correct configuration errors instead of e.g. finding which values are acceptable in the docs.