Auth policy merge strategy#652
Merged
crstrn13 merged 1 commit intoKuadrant:mainfrom Jun 11, 2025
Merged
Conversation
azgabur
reviewed
Mar 18, 2025
averevki
reviewed
Mar 18, 2025
Contributor
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
Agreed with Alex on trying to use and overwrite different identities for AuthPolicy tests. Try to not just mirror tests RateLimitPolicy has. RateLimitPolicy has pretty small amount of things you can overwrite (basically only requests rate-limiting), when AuthPolicy has different identities for you to play with. See if you can come up with some scenarios that customer can setup when using the Kuadrant
P.S. these are only the Defaults tests right? Don't forget to mark somewhere that Overrides still need merge strategy tests. Thanks
azgabur
reviewed
Mar 24, 2025
azgabur
reviewed
Mar 28, 2025
crstrn13
force-pushed
the
auth_policy_merge_strategy
branch
4 times, most recently
from
ba9b373 to
8eb7e40
Compare
averevki
reviewed
May 16, 2025
averevki
reviewed
May 28, 2025
averevki
reviewed
Jun 2, 2025
crstrn13
force-pushed
the
auth_policy_merge_strategy
branch
2 times, most recently
from
3b9dd18 to
bacab24
Compare
crstrn13
force-pushed
the
auth_policy_merge_strategy
branch
3 times, most recently
from
bacab24 to
8196f61
Compare
averevki
reviewed
Jun 11, 2025
averevki
reviewed
Jun 11, 2025
Contributor
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
Verifed with make kuadrant. LGTM! Please squash and ready to merge
averevki
approved these changes
Jun 11, 2025
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
crstrn13
force-pushed
the
auth_policy_merge_strategy
branch
from
01732a8 to
6a88daf
Compare
averevki
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix issue: #635.
Mirrored existing test suite for rate limit policies and applied them to auth policies.