Refactor/Add testsuite release workflow#663
Merged
trepel merged 1 commit intoKuadrant:mainfrom Apr 14, 2025
Merged
Conversation
Signed-off-by: averevki <sandyverevkin@gmail.com>
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- .github/workflows/build_release_image.yml: Language not supported
- .github/workflows/promote_to_latest.yml: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:20
- [nitpick] Consider quoting the IMG_TAGS value to ensure proper YAML parsing and to avoid any unintended splitting of the tag string.
IMG_TAGS: latest ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.version_tag || github.ref_name }}
.github/workflows/build_unstable_image.yml:12
- [nitpick] Verify that combining 'unstable' with the commit SHA as a space-separated string produces the intended tag format, and consider quoting or reformatting if necessary to match the expected input for the build action.
IMG_TAGS: unstable ${{ github.sha }}
.github/workflows/acceptance.yml:1
- [nitpick] Ensure that the new workflow name 'Code static analysis' accurately reflects the workflow's purpose if it still encompasses broader acceptance tests.
name: Code static analysis
trepel
approved these changes
Apr 14, 2025
Contributor
trepel
left a comment
There was a problem hiding this comment.
LGTM - I managed to make this work using my own fork. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
:latestand:${version}images to the quay, and create new testsuite github release.Closes #79 Closes #242
Verification steps
Eye review
--OR--
Merge this change to your testsuite fork, add
IMG_REGISTRY_USERNAME(quay.io username) andIMG_REGISTRY_TOKEN(quay.io password) to your fork project actions secrets(to be able to push to quay/testsuite). Activate release workflow on github actions page. Push the version tag to activate release workflow.