Update failing change_targetref tests#665
Merged
averevki merged 1 commit intoKuadrant:mainfrom Apr 26, 2025
Merged
Conversation
Signed-off-by: emmaaroche <eroche@redhat.com>
averevki
approved these changes
Apr 26, 2025
Contributor
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
LGTM. Let's see if this helps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the failing
change_targetreftests as described in issue #664.Changes:
Solution for now is to add
time.sleep(10)to both tests, comments in code explain reasoning. In the future, when issue Investigate smarter waits #660 is addressed, there could be a better solution in place of this.Added
has_tls_error()method totestsuite/httpx/__init__.pyUpdated assertions in
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/test_update_tlspolicy_target_ref.pyto useassert response.has_tls_error()instead of directly checking for a specific SSL error message viaresponse.has_error("[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol").