Parallel creation for multicluster gateways#678
Merged
azgabur merged 1 commit intoKuadrant:mainfrom Jun 12, 2025
Merged
Conversation
Member
Author
|
Due to the nature of DNSPolicy testing and DNS caching I no longer think that making gateways have session scope is a good change. At least if we do not rotate the hostname per module |
averevki
reviewed
May 28, 2025
13cdaba to
464cf05
Compare
averevki
previously approved these changes
Jun 9, 2025
Signed-off-by: Alex Zgabur <azgabur@redhat.com>
averevki
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the gateways have module scope and are created sequentially. This PR changes the scope to session and allows for both gateways on both clusters to start reconciling in parallel (useful for the recent addition of
-n2parallelism)