Get GatewayClass name from cluster#685
Merged
trepel merged 1 commit intoKuadrant:mainfrom Jun 10, 2025
Merged
Conversation
trepel
force-pushed
the
get-gw-class-name-from-cluster
branch
from
2a0b387 to
9fd0890
Compare
azgabur
reviewed
Jun 6, 2025
Member
azgabur
left a comment
azgabur
left a comment
There was a problem hiding this comment.
In the current state the testsuite/tests/singlecluster/gateway/test_basic.py test passes and all seems to be working in order
trepel
force-pushed
the
get-gw-class-name-from-cluster
branch
from
380f6d0 to
636e110
Compare
Signed-off-by: Tomas Repel <trepel@redhat.com>
trepel
force-pushed
the
get-gw-class-name-from-cluster
branch
from
636e110 to
7be6156
Compare
azgabur
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of using hard-coded 'istio' the proper name of GatewayClass CR is used based on what is actually present in cluster.
Reason: in OCP v4.19 the GatewayClass CR won't be called 'istio' but 'openshift-default' by default. Also we might need to support other names - users can create GatewayClasse CR with arbitrary name and Kuadrant supports that so our test suite should be ready for that too.
Verification Steps
I don't think that we have OCP v4.19 cluster with 'openshift-default' GatewayClass CR so the simplest way of verification is to run some test against some cluster:
make testsuite/tests/singlecluster/gateway/test_basic.py::test_gateway_readiness
Then change the 'openshift-default' in code to 'istio-remote' (that is another GatewayClass custom resource present on clusters), run the test again and validate that Gateway CR that gets created uses 'istio-remote' as a GatewayClass name