Skip to content

Scale gateway tests.#690

Merged
azgabur merged 1 commit intoKuadrant:mainfrom
crstrn13:scale_gateways
Aug 20, 2025
Merged

Scale gateway tests.#690
azgabur merged 1 commit intoKuadrant:mainfrom
crstrn13:scale_gateways

Conversation

@crstrn13
Copy link
Copy Markdown
Contributor

This PR aims to fix issue: #559

@crstrn13 crstrn13 requested review from averevki and azgabur June 12, 2025 13:59
@crstrn13 crstrn13 changed the title Scale gateways tests. Scale gateway tests. Jun 12, 2025
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_manual_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
@crstrn13 crstrn13 requested a review from averevki June 17, 2025 09:24
Copy link
Copy Markdown
Member

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test cases seem very similar so I would surely reuse some fixtures in a conftest if needed

Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_manual_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
Comment thread testsuite/kubernetes/deployment.py
Comment thread testsuite/tests/singlecluster/gateway/scaling/conftest.py Outdated
@azgabur
Copy link
Copy Markdown
Member

azgabur commented Jul 24, 2025

Please also add new object types here: https://github.com/Kuadrant/testsuite/blob/main/Makefile#L112

@crstrn13 crstrn13 self-assigned this Aug 1, 2025
Comment thread testsuite/custom_metrics_apiserver/client.py Outdated
Comment thread testsuite/custom_metrics_apiserver/client.py Outdated
Comment thread config/settings.yaml Outdated
Comment thread testsuite/kubernetes/monitoring/__init__.py Outdated
Comment thread testsuite/tests/singlecluster/conftest.py
Comment thread testsuite/tests/singlecluster/gateway/scaling/conftest.py
Comment thread testsuite/tests/singlecluster/gateway/scaling/test_auto_scale_gateway.py Outdated
azgabur
azgabur previously approved these changes Aug 20, 2025
@azgabur
Copy link
Copy Markdown
Member

azgabur commented Aug 20, 2025

Just be sure to squash the commits before merge

@crstrn13 crstrn13 force-pushed the scale_gateways branch 2 times, most recently from 07c551a to 1abfc4f Compare August 20, 2025 13:49
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
@azgabur azgabur merged commit 351ab33 into Kuadrant:main Aug 20, 2025
3 checks passed
@crstrn13 crstrn13 deleted the scale_gateways branch August 20, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants