Skip to content

Add tests for observability configuration and functional behavior#695

Merged
emmaaroche merged 1 commit intoKuadrant:mainfrom
emmaaroche:observability-e2e-tests
Jul 25, 2025
Merged

Add tests for observability configuration and functional behavior#695
emmaaroche merged 1 commit intoKuadrant:mainfrom
emmaaroche:observability-e2e-tests

Conversation

@emmaaroche
Copy link
Copy Markdown
Contributor

@emmaaroche emmaaroche commented Jun 26, 2025 •
edited
Loading

Description:

This PR introduces tests that validate Kuadrant's observability functionality.

Observability Tests Validate:

  • ServiceMonitor and PodMonitor resources exist and are labeled with 'kuadrant.io/observability=true'
  • Prometheus successfully scrapes metrics from each monitor’s configured endpoints
  • All expected ServiceMonitor metrics (e.g., controller_runtime, workqueue) are present per service
  • All expected PodMonitor metrics (e.g., Istio metrics) are present
  • Predictable PodMonitor metrics (like istio_requests_total) have exactly 2 source-side samples with value 1 each

Note: These tests currently cover observability integration with Istio-based gateways. Coverage for Envoy Gateway is not included at this time.

Related Issues / PRs:

@emmaaroche emmaaroche self-assigned this Jun 26, 2025
@emmaaroche emmaaroche added the Test case New test case label Jun 26, 2025
@emmaaroche emmaaroche requested a review from averevki June 26, 2025 11:33
@emmaaroche
Copy link
Copy Markdown
Contributor Author

emmaaroche commented Jun 27, 2025

Note: refactoring these tests further based on feedback in call with @averevki.

@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from 3339a5c to ac4378c Compare July 1, 2025 13:55
emmaaroche
emmaaroche commented Jul 1, 2025
View reviewed changes
Comment thread testsuite/prometheus.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from ac4378c to f65f99f Compare July 1, 2025 14:00
averevki
averevki reviewed Jul 1, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/prometheus.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from f65f99f to f895574 Compare July 2, 2025 13:58
@emmaaroche emmaaroche requested a review from averevki July 2, 2025 14:00
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from f895574 to 03a1415 Compare July 2, 2025 14:04
azgabur
azgabur reviewed Jul 3, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
averevki
averevki reviewed Jul 3, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py
Comment thread testsuite/tests/singlecluster/observability/conftest.py
Comment thread testsuite/prometheus.py Outdated
Comment thread testsuite/kuadrant/__init__.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from 03a1415 to d05dcb9 Compare July 4, 2025 11:51
averevki
averevki reviewed Jul 4, 2025
View reviewed changes
Comment thread testsuite/prometheus.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/kuadrant/__init__.py
Comment thread testsuite/kuadrant/__init__.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from d05dcb9 to abdda4c Compare July 7, 2025 15:27
emmaaroche
emmaaroche commented Jul 7, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
@emmaaroche emmaaroche requested a review from averevki July 7, 2025 15:32
averevki
averevki reviewed Jul 14, 2025
View reviewed changes
Comment thread testsuite/kuadrant/__init__.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from abdda4c to 7391cfd Compare July 16, 2025 14:13
emmaaroche
emmaaroche commented Jul 16, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/test_observability.py
@emmaaroche emmaaroche requested a review from averevki July 16, 2025 14:31
averevki
averevki reviewed Jul 18, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/conftest.py
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from 7391cfd to 496de3a Compare July 22, 2025 13:40
averevki
averevki reviewed Jul 22, 2025
View reviewed changes
Comment thread testsuite/tests/singlecluster/observability/conftest.py
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/conftest.py Outdated
Comment thread testsuite/tests/singlecluster/observability/test_observability.py Outdated
Comment thread testsuite/prometheus.py Outdated
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from 496de3a to bbcf354 Compare July 23, 2025 10:26
@emmaaroche emmaaroche requested a review from averevki July 23, 2025 10:26
averevki
averevki reviewed Jul 23, 2025
View reviewed changes
Comment thread testsuite/prometheus.py Outdated
@emmaaroche
Add tests for observability configuration and functional behavior
5ab636a 
Signed-off-by: emmaaroche <eroche@redhat.com>
@emmaaroche emmaaroche force-pushed the observability-e2e-tests branch from bbcf354 to 5ab636a Compare July 23, 2025 13:23
@emmaaroche emmaaroche requested a review from averevki July 23, 2025 13:23
@emmaaroche emmaaroche merged commit a99e243 into Kuadrant:main Jul 25, 2025
3 checks passed
@emmaaroche emmaaroche deleted the observability-e2e-tests branch July 25, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averevki averevki averevki approved these changes

@azgabur azgabur azgabur approved these changes

Assignees

@emmaaroche emmaaroche

Labels

Test case New test case

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmaaroche @averevki @azgabur