Update change_targetref tests to fix azure DNS issue#697
Merged
emmaaroche merged 1 commit intoKuadrant:mainfrom Jul 1, 2025
Merged
Update change_targetref tests to fix azure DNS issue#697emmaaroche merged 1 commit intoKuadrant:mainfrom
emmaaroche merged 1 commit intoKuadrant:mainfrom
Conversation
averevki
reviewed
Jun 27, 2025
eabf5ac to
d59de09
Compare
averevki
reviewed
Jul 1, 2025
Signed-off-by: emmaaroche <eroche@redhat.com>
d59de09 to
726beb1
Compare
averevki
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue described in #696. This fix aims to help avoid inconsistent test failures when DNS records take time to propagate, especially on Azure.
What was the issue
Some
change_targetreftests run before DNS is fully ready. Even though the DNSPolicy was created successfully, its status showed:With recordConditions stuck in:
This caused test traffic to hit unresolved hostnames and fail with DNS-related errors (nodename nor servname provided).
Changes
Refactored DNS readiness logic into the
dns_policy2fixture:Waits for
recordConditionsto report"Ready"withstatus=TrueWaits until the associated hostname successfully resolves (via
is_nxdomain)This ensures tests don’t proceed until DNS is actually ready
Note: The helper is not used in the DNSPolicy test, that test is expected to hit a DNS failure.
Related issue
Closes #696.