Added kuadrant mark to modified test with generation.#698
Added kuadrant mark to modified test with generation.#698azgabur merged 1 commit intoKuadrant:mainfrom
Conversation
azgabur
left a comment
There was a problem hiding this comment.
Hmm, not sure if this is the best resolution. Yes it will stop the error but we will loose coverage on authorino standalone testing. Especially if the problem is not really in the use case. Could you maybe revise the way the generation field is checked in the wait_for_ready instead? Maybe overriding the method in AuthConfig class which is only CR that doesnt have generation field?
azgabur
left a comment
There was a problem hiding this comment.
Im thinking how to do this better way. We would like to avoid using isinstance() in tests but I think this needs maybe bigger backend change and better OOP design of this wait for generation increment. I always thought this wait should be internal to the wait_for_ready method and which should not require any parameter.
We know that AuthConfig does not have generation is status so its impossible to wait for it.
What if all changes via modify_and_apply on Policy class and subclasses would update a state with tells if changes have been pushed to cluster. Something like the .committed property of KubernetesObject. That could be used by wait_for_ready() function to see if there has been a change since first creation and therefore it would wait for observedGeneration
azgabur
left a comment
There was a problem hiding this comment.
I ran make test and make authorino-standalone and all tests passed with this modification.
f6a15c8 to
0bc8228
Compare
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
Description
Added kuadrant mark to fix failing test on AuthConfig.