Improve apply() logic#718
Merged
averevki merged 1 commit intoKuadrant:mainfrom Aug 5, 2025
Merged
Conversation
averevki
force-pushed
the
remove-apply-asserts
branch
from
4a168ab to
a56c9e9
Compare
Signed-off-by: averevki <sandyverevkin@gmail.com>
averevki
force-pushed
the
remove-apply-asserts
branch
from
a56c9e9 to
8a3813a
Compare
emmaaroche
approved these changes
Aug 5, 2025
Contributor
emmaaroche
left a comment
emmaaroche
left a comment
There was a problem hiding this comment.
LGTM 👍 Encountered a few test failures while running the verification steps, but confirmed they are unrelated to the apply() refactor or the removed assertions.
Member
|
Most important place where testsuite/testsuite/kubernetes/__init__.py Line 116 in 8a3813a was it migrated to apply?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed related asserts from dns tests, leftover from #654
Verification steps
make dnstls,make testsuite/tests/singlecluster/gateway/reconciliation/change_targetref