Limitador storage#727
Conversation
0b25743 to
2501ed7
Compare
|
My local test run finished with 2 failed, 9 passed, 3 xfailed. Here's a summary of the durability tests: test_durability for Dragonfly: PASSED test_durability for RedisCached (redis, dragonfly, valkey): XFAIL (as you expected in bug) test_durability for Redis and Valkey: FAILED The interesting part is that the test_durability for plain Redis and Valkey failed for the exact same reason as bug #197 (AssertionError: assert 200 == 429 after the pod restart). It seems bug #197 affects not just RedisCached, but also the standard Redis and Valkey storages. To make the test suite pass cleanly, maybe we could add an xfail marker to test_redis.py's durability test as well, referencing the same issue? |
2501ed7 to
936d943
Compare
Yes I noticed these errors too, but they seem random and not as consistent as the bug Kuadrant/limitador-operator#197. After re-running the failed tests, they pass again. But it is possible it is connected. I will mention it in the issue. Additionally I do not think xfail is needed here as the tests pass 90% of the time, they are problematic when running together with the Cached tests |
936d943 to
10c76c3
Compare
|
^ changed rate_limit fixture as it was not acting as "function" scope |
460831c to
139ad64
Compare
Refactor deprecated kuadrant sections Add rollout for Deployment Refactor fetch_service_ip method to be more compatible with fetch_service method Signed-off-by: Alex Zgabur <azgabur@redhat.com>
Signed-off-by: Alex Zgabur <azgabur@redhat.com>
139ad64 to
3d5adb7
Compare
|
/make disruptive |
|
Test run has started ( |
Work on #676
Adds basic durability tests for Limitador storage feature. It contains xfail for a bug Kuadrant/limitador-operator#197 which should be removed in future when the bug is fixed.
Also contains:
Verification steps
Work left to do in next PR