Add GitHub Action to run testsuite on PRs#734
Merged
averevki merged 1 commit intoKuadrant:mainfrom Aug 27, 2025
Merged
Conversation
Contributor
Author
|
Test run completed ( Short Test SummaryFull Output |
Contributor
Author
|
^example of final output after sending comment with |
trepel
previously approved these changes
Aug 27, 2025
Contributor
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
I am not very familiar with GitHub Actions but this looks great. I apparently works and I did not spot anything that would block merging.
LGTM
Do you plan to introduce this for kuadrant-operator repository as well?
I could not find timeout being set in any of our GitHub actions so we apparently are not using this but it might be something to consider:
jobs:
kuadrant-test:
timeout-minutes: 120 # Add reasonable timeout
Did you intentionally use hard-coded versions? For instance golang version is hard-coded to v1.24 etc
crstrn13
reviewed
Aug 27, 2025
Signed-off-by: averevki <sandyverevkin@gmail.com>
averevki
force-pushed
the
kind-gh-action
branch
from
f4197d3 to
d483e4f
Compare
Contributor
Author
@trepel Yes, this is one of the steps for this "epic" #671
Good one, pushed the change. 120 seems like a reasonable timeout
I can't remember everything but most of the kuadrant-operator dependencies versions here are taken from the official kuadrant helm. kind has dependency on go version if I remember correctly. There are no officially supported k8s dependencies versions we're testing with afaik, so everything assembled to just work with testsuite for now P.S. This action could also be used as regular testing env for latest kuadrant helm, know I'm thinking about it |
crstrn13
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a GitHub Actions workflow that enables running testsuite commands on pull requests through issue comments. The workflow provides a convenient way to test PRs without requiring manual setup of test environments.
Changes Made
.github/workflows/test-pr.yml: Complete GitHub Actions workflow for PR testing/make <target>Verification Steps
Eye review is sufficient for this PR. The workflow is self-contained and includes comprehensive environment setup that mirrors the existing testsuite requirements.
Future works
Closes #735 Closes Kuadrant/architecture#43