Skip to content

Add workflow for re-enabling workflows after 60 day inactivity#738

Merged
Patryk-Stefanski merged 2 commits intoKuadrant:mainfrom
Patryk-Stefanski:add-re-enable-workflows-workflow
Sep 3, 2025
Merged

Add workflow for re-enabling workflows after 60 day inactivity#738
Patryk-Stefanski merged 2 commits intoKuadrant:mainfrom
Patryk-Stefanski:add-re-enable-workflows-workflow

Conversation

@Patryk-Stefanski
Copy link
Copy Markdown
Contributor

@Patryk-Stefanski Patryk-Stefanski commented Aug 27, 2025

closes #737

Adds a workflow that will run twice a week to check if any workflows are disabled due to inactivity and will automatically re-enable those workflows.

This pr is checking for DISABLED_MANUALLY so that the workflow can be tested. A follow-up pr will change this to disabled_inactivity, which is the state the workflow is in when disabled due to inactivity.

Copy link
Copy Markdown
Member

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is one thing that I feel needs to be address, that is the silent failures.

The others are question.

Side not I don't like the idea of writing bash scripts with in yaml files. We lose the advantages IDEs, and syntax highlighting.

Comment thread .github/workflows/re-enable-disabled-workflows.yml Outdated
Comment thread .github/workflows/re-enable-disabled-workflows.yml
Comment thread .github/workflows/re-enable-disabled-workflows.yml
Comment thread .github/workflows/re-enable-disabled-workflows.yml
Copy link
Copy Markdown
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think testsuite has any scheduled workflows at all. Will it just be running by itself 2 times a week?

@Patryk-Stefanski
Copy link
Copy Markdown
Contributor Author

I don't think testsuite has any scheduled workflows at all. Will it just be running by itself 2 times a week?

Yeah bit of a chicken and egg situation here, so I suppose we can remove the tessuite from the list of repos. And yes it will be running by itself 2 times a week. I think we can move it to run once a week after 60 days.

@averevki
Copy link
Copy Markdown
Contributor

Yeah bit of a chicken and egg situation here, so I suppose we can remove the tessuite from the list of repos. And yes it will be running by itself 2 times a week. I think we can move it to run once a week after 60 days.

We can have it just running, maybe increase interval a bit so it is not that often.

If every repo will contain this action, it won't be a problem to just copy it here in the future, when any scheduled action appears or activity in the repo slows down 🤷‍♂️. Maybe I'm missing the point of adding this to every repo without a thought

@Patryk-Stefanski
Copy link
Copy Markdown
Contributor Author

f every repo will contain this action, it won't be a problem to just copy it here in the future, when any scheduled action appears or activity in the repo slows down 🤷‍♂️. Maybe I'm missing the point of adding this to every repo without a thou

Because this runs on a schedule, if we add it to a repository that hits the 60-day inactivity mark, this workflow itself will also be disabled. The idea is to have this in one active repository so that it ensures workflows in all other repositories are always running.

@Patryk-Stefanski
Copy link
Copy Markdown
Contributor Author

We can have it just running, maybe increase interval a bit so it is not that often.

I think once a week would be alright for the time being.

Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski Patryk-Stefanski force-pushed the add-re-enable-workflows-workflow branch from 7dd3644 to f879ca4 Compare August 27, 2025 16:02
Copy link
Copy Markdown
Member

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, to add a bit more logging, then we will be good to merge this.

Comment thread .github/workflows/re-enable-disabled-workflows.yml
…ries with scheduled workflows

Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski Patryk-Stefanski force-pushed the add-re-enable-workflows-workflow branch from 252c785 to 72c63bf Compare September 2, 2025 08:50
Copy link
Copy Markdown
Member

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me

@Patryk-Stefanski Patryk-Stefanski merged commit 3a19a5e into Kuadrant:main Sep 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add workflow for enabling disabled workflows for Kuadrant components

3 participants