Skip to content

Scale test: cleanup condition fix and httpbin image update#739

Merged
trepel merged 1 commit intoKuadrant:mainfrom
trepel:images-and-cleanup
Sep 1, 2025
Merged

Scale test: cleanup condition fix and httpbin image update#739
trepel merged 1 commit intoKuadrant:mainfrom
trepel:images-and-cleanup

Conversation

@trepel
Copy link
Copy Markdown
Contributor

@trepel trepel commented Aug 29, 2025

Description

Cleanup condition fix and httpbin image update in scale test.

Verification Steps

Eye review probably suffice. The cleanup condition is relatively trivial and the httpbin image had been validated as part of review of #729

If you want to be thorough you can run the scale test as described in scale-test/control-plane.md several times with various values for SKIP_CLEANUP env var:

  • have it undefined (unset SKIP_CLEANUP) -> error saying that you need to define it
  • have it empty (SKIP_CLEANUP= # empty) -> success with cleanup
  • have it set to true (SKIP_CLEANUP=true) -> success without cleanup
  • have it set to false (SKIP_CLEANUP=false) -> success with cleanup

Signed-off-by: Tomas Repel <trepel@redhat.com>
@trepel trepel requested a review from averevki August 29, 2025 14:12
@trepel trepel merged commit d5780f5 into Kuadrant:main Sep 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants