OIDC policy#740
Merged
crstrn13 merged 1 commit intoKuadrant:mainfrom Nov 6, 2025
Merged
Conversation
crstrn13
force-pushed
the
oidc-policy
branch
from
917ba06 to
8fd46a6
Compare
trepel
requested changes
Sep 22, 2025
averevki
reviewed
Sep 30, 2025
averevki
reviewed
Oct 1, 2025
Merged
averevki
reviewed
Oct 22, 2025
Contributor
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
"Error from server (BadRequest): error when creating \"STDIN\": OIDCPolicy in version \"v1alpha1\" cannot be handled as a OIDCPolicy: strict decoding error: unknown field \"spec.provider.clientSecret\"\n"
tbh it is very hard to understand what these test are doing now. I don't see you add any new classes/methods to delegate the setup logic from the test, you only work with functions and fixtures which can be converted and reused later if they are part of the testsuite structure.
I see you are doing a lot of asserts here now. Do you actually check for properties that kuadrant adds? Or some of the asserts check for values added from keycloak and standard protocols? I think starting with simpler oidcpolicy test will be more helpful, but I might be wrong as I didn't understand these tests completely yet lol
averevki
reviewed
Oct 22, 2025
crstrn13
force-pushed
the
oidc-policy
branch
2 times, most recently
from
d13c7ad to
f5661a4
Compare
averevki
requested changes
Nov 3, 2025
Contributor
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
"Error from server (BadRequest): error when creating \"STDIN\": OIDCPolicy in version \"v1alpha1\" cannot be handled as a OIDCPolicy: strict decoding error: unknown field \"spec.provider.clientSecret\"\n"
averevki
reviewed
Nov 3, 2025
averevki
reviewed
Nov 5, 2025
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added OIDC policy extension tests for Authorino, covering different authentication flows and hostname configurations.
Test Coverage
Each flow tested against:
Requirements
@pytest.mark.extensions)