Add model label support and improve TRLP metric test logic#791
Merged
emmaaroche merged 1 commit intoKuadrant:mainfrom Oct 15, 2025
Merged
Add model label support and improve TRLP metric test logic#791emmaaroche merged 1 commit intoKuadrant:mainfrom
emmaaroche merged 1 commit intoKuadrant:mainfrom
Conversation
trepel
reviewed
Oct 15, 2025
trepel
reviewed
Oct 15, 2025
Signed-off-by: emmaaroche <eroche@redhat.com>
emmaaroche
force-pushed
the
trlp-metrics-model-label
branch
from
8709676 to
c2667dc
Compare
trepel
approved these changes
Oct 15, 2025
Contributor
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
Great work! Tests passed for me and code looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the TRLP metric tests to include validation for the new
modellabel introduced in Kuadrant v1.3.0. It also adds relevant pytest markers and refactors test logic to reduce duplication of test code.Closes Kuadrant/kuadrant-operator#1626