Refactor gateway listener in dns section target test#799
Merged
azgabur merged 1 commit intoKuadrant:mainfrom Oct 23, 2025
Merged
Refactor gateway listener in dns section target test#799azgabur merged 1 commit intoKuadrant:mainfrom
azgabur merged 1 commit intoKuadrant:mainfrom
Conversation
azgabur
force-pushed
the
dns_section_refactor
branch
2 times, most recently
from
17cdb58 to
d223cc1
Compare
averevki
reviewed
Oct 23, 2025
Contributor
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
Good catch, but why do you want to use tlspolicy together with dnspolicy in this test? It should only test the section name change in dnspolicy. More atomic, if you will 😁
Member
Author
|
Yes another solution is to make the clients http, which is maybe better solution come to think of it 🤔 The test can have wildcard listener as the more specific hostname listener will be used instead of the wildcard when a request comes, of course not if they are on different ports as happened here.. You could remove the default listener and have only the managed and unmanaged ones but it makes little difference. I will add it regardless |
Signed-off-by: Alex Zgabur <azgabur@redhat.com>
azgabur
force-pushed
the
dns_section_refactor
branch
from
d223cc1 to
352adca
Compare
Contributor
|
/make dnstls |
|
Test run completed ( Short Test SummaryFull Output |
averevki
approved these changes
Oct 23, 2025
|
Test run completed ( Short Test SummaryFull Output |
Contributor
|
@azgabur I'm looking at the last CI run and I don't quite understand the failure - dns.resolver.NoAnswer. Could you explain what this failure means, please? |
Member
Author
|
The github action bot and also my local ISP provider have access to dns resolvers that check dnssec so the error on some tests happening when
I will take a look at second solution if it wont be feasible I will just turn off the dnssec |
Contributor
|
thanks for explanation! |
fabikova
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test worked previously too, but the gateway setup had one flaw. Resulting gateway had the default wildcard listener and the additional managed and unmanaged listeners, but these were http only. The client fixtures were using https protocol so it actually connected to the wildcard listener instead, not the managed or unamanaged listener.
I know this is a small change and it has no impact on the test result but for the future if the test would be changing it would solve some debugging time..
to verify: