Skip to content

refactor: adjust observability tests for additional ServiceMonitor#828

Merged
emmaaroche merged 1 commit intoKuadrant:mainfrom
emmaaroche:update-observability-tests
Dec 15, 2025
Merged

refactor: adjust observability tests for additional ServiceMonitor#828
emmaaroche merged 1 commit intoKuadrant:mainfrom
emmaaroche:update-observability-tests

Conversation

@emmaaroche
Copy link
Copy Markdown
Contributor

Description

Updated testsuite/tests/singlecluster/observability/test_observability.py to account for the newly added ServiceMonitor resource, kuadrant-authorino-monitor. The service_monitors fixture now expects 5 ServiceMonitor instances instead of 4 when observability is enabled.

Closes #827.

Changes

  • Updated testsuite/tests/singlecluster/observability/conftest.py:
    • Increased expected ServiceMonitor count from 4 to 5
    • Adjusted the backoff.on_predicate condition accordingly
    • Updated the fixture docstring and assertion message

Verification

Run the observability test to confirm the updated expectations:

poetry run pytest testsuite/tests/singlecluster/observability/test_observability.py::test_service_monitor_metrics_per_service

Signed-off-by: emmaaroche <eroche@redhat.com>
@emmaaroche emmaaroche self-assigned this Dec 15, 2025
Copy link
Copy Markdown
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the observability tests, 22/22 passed 👍

Copy link
Copy Markdown
Contributor

@crstrn13 crstrn13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

@emmaaroche emmaaroche merged commit 9bd9872 into Kuadrant:main Dec 15, 2025
4 checks passed
@emmaaroche emmaaroche deleted the update-observability-tests branch December 15, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update observability tests

3 participants