Skip to content

fix: remove --enforce from observability make target#829

Merged
averevki merged 1 commit intoKuadrant:mainfrom
averevki:dont-enforce-observability-tests
Dec 15, 2025
Merged

fix: remove --enforce from observability make target#829
averevki merged 1 commit intoKuadrant:mainfrom
averevki:dont-enforce-observability-tests

Conversation

@averevki
Copy link
Copy Markdown
Contributor

Summary

The new make observability target fails some tests that could only run under testsuite configuration for standalone authorino (aka with --standalone flag). Removing --enforce flag from observability target so it is possible run it with either standard authorino or with standalone authorino by adding --standalone flag to the observability target.

ERROR testsuite/tests/singlecluster/authorino/metrics/test_deep_metrics.py::test_deep_metrics[authorization] - Failed: Unable to run Standalone only test: Standalone mode is disabled, please use --standalone flag
ERROR testsuite/tests/singlecluster/authorino/metrics/test_deep_metrics.py::test_deep_metrics[identity] - Failed: Unable to run Standalone only test: Standalone mode is disabled, please use --standalone flag
ERROR testsuite/tests/singlecluster/authorino/metrics/test_deep_metrics.py::test_deep_metrics[metadata] - Failed: Unable to run Standalone only test: Standalone mode is disabled, please use --standalone flag
ERROR testsuite/tests/singlecluster/authorino/metrics/test_deep_metrics.py::test_deep_metrics[response] - Failed: Unable to run Standalone only test: Standalone mode is disabled, please use --standalone flag
ERROR testsuite/tests/singlecluster/authorino/operator/tracing/test_tracing.py::test_tracing - Failed: Unable to run Standalone only test: Standalone mode is disabled, please use --standalone flag
ERROR testsuite/tests/singlecluster/authorino/operator/tracing/test_tracing_tags.py::test_tracing_tags - Failed: Unable to run Standalone only test: Standalone mode is disabled, please use --standalone flag

Verification steps

# run mark with the standard authorino and see how some metrics and tracing tests will be skipped instead of failed
flags=-vv make observability

# run only observability tests capable running with standalone authorino
flags="-vv --standalone" make observability

@averevki averevki requested a review from silvi-t December 15, 2025 14:47
@averevki averevki self-assigned this Dec 15, 2025
@averevki averevki added the bug Something isn't working label Dec 15, 2025
@averevki averevki force-pushed the dont-enforce-observability-tests branch 2 times, most recently from 03b17cf to 0736474 Compare December 15, 2025 14:57
Signed-off-by: averevki <sandyverevkin@gmail.com>
@averevki averevki force-pushed the dont-enforce-observability-tests branch from 0736474 to 8a4dd55 Compare December 15, 2025 14:59
Copy link
Copy Markdown
Contributor

@silvi-t silvi-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Contributor

@crstrn13 crstrn13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 :shipit:

Copy link
Copy Markdown
Contributor

@emmaaroche emmaaroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@averevki averevki merged commit 72acb09 into Kuadrant:main Dec 15, 2025
4 checks passed
@averevki averevki deleted the dont-enforce-observability-tests branch December 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants