Skip to content

fix: ensure macOS/Linux compatibility in polish-junit target#849

Merged
averevki merged 1 commit intoKuadrant:mainfrom
silvi-t:polish-junit-macOS
Jan 29, 2026
Merged

fix: ensure macOS/Linux compatibility in polish-junit target#849
averevki merged 1 commit intoKuadrant:mainfrom
silvi-t:polish-junit-macOS

Conversation

@silvi-t
Copy link
Copy Markdown
Contributor

@silvi-t silvi-t commented Jan 20, 2026

Description

  • Improved the polish-junit Makefile target to ensure cross-platform compatibility between macOS and Linux

Changes

  • Makefile: Refactored polish-junit target for macOS/Linux compatibility
    • Replaced zcat command with gunzip -c (works on both macOS and Linux)
    • Added check for junit XML files existence before processing
    • Added file existence validation within the loop
    • Improved error handling with explicit exit code when no files found
    • Removed error suppression (-rm) that was marked as "dangerous" - now only deletes files created in the same command block
    • Eliminated bashisms in favor of POSIX-compliant shell syntax for better cross-platform portability

Verification steps

  1. First, generate junit XML files by running tests:
    make testsuite/tests/<test_path> junit=1
  2. Verify the polish-junit target processes the files correctly:
    make polish-junit
  3. Or run make reportportal to test the full workflow (ensure all required environment variables are set: RP_TOKEN, REPORTPORTAL, RP_LAUNCH_NAME, RP_PROJECT, REQUESTS_CA_BUNDLE)
  4. Test on both macOS and Linux environments to ensure cross-platform compatibility

Signed-off-by: Silvia Tarabova <starabov@redhat.com>
Copy link
Copy Markdown
Contributor

@emmaaroche emmaaroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through verification steps and looks good on macOS 👍

@silvi-t silvi-t self-assigned this Jan 21, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in Kuadrant QE Jan 21, 2026
@silvi-t silvi-t moved this to Ready For Review in Kuadrant Jan 21, 2026
@silvi-t silvi-t moved this from 🆕 New to 🏗 In progress in Kuadrant QE Jan 21, 2026
@silvi-t silvi-t moved this from 🏗 In progress to In Review in Kuadrant QE Jan 21, 2026
@averevki averevki merged commit 20622d6 into Kuadrant:main Jan 29, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to ✅ Done in Kuadrant QE Jan 29, 2026
@github-project-automation github-project-automation Bot moved this from Ready For Review to Done in Kuadrant Jan 29, 2026
@silvi-t silvi-t deleted the polish-junit-macOS branch February 23, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants