Skip to content

fix: update DNS provider error message assertion#853

Merged
averevki merged 1 commit intoKuadrant:mainfrom
trepel:no-dns-provider-secret-fix
Feb 2, 2026
Merged

fix: update DNS provider error message assertion#853
averevki merged 1 commit intoKuadrant:mainfrom
trepel:no-dns-provider-secret-fix

Conversation

@trepel
Copy link
Copy Markdown
Contributor

@trepel trepel commented Feb 2, 2026

Description

Update expected error message in test_no_dns_provider_secret.py to match the current error format. The error message now uses lowercase "secrets" instead of "Secret".

Changes

  • Fix test assertion to match updated DNS provider error message format

Verification

make ./testsuite/tests/singlecluster/gateway/dnspolicy/test_no_dns_provider_secret.py


PR Title Guidelines (Conventional Commits)

Your PR title must follow the conventional commit format:

<type>[optional scope]: <description>

Examples:

  • feat: add rate limiting policy for gateways
  • feat(gateway): add rate limiting policy
  • fix(authorino): resolve authorization timeout issue
  • test: add tests for DNS policy reconciliation
  • docs: update installation guide

Allowed types:

  • feat - New feature
  • fix - Bug fix
  • docs - Documentation changes
  • style - Code style changes (formatting, no logic change)
  • refactor - Code refactoring
  • perf - Performance improvements
  • test - Adding or updating tests
  • build - Build system changes
  • ci - CI/CD changes
  • chore - Other changes (dependencies, tooling)
  • revert - Revert a previous commit

Optional scopes:

  • authorino, chore, ci, dns, docs, gateway, limitador, multicluster, perf, refactor, style, test, tls

Signed-off-by: Tomas Repel <trepel@redhat.com>
@trepel trepel requested review from averevki and silvi-t February 2, 2026 10:41
Copy link
Copy Markdown
Contributor

@silvi-t silvi-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test passed.

@averevki averevki merged commit 85ab14a into Kuadrant:main Feb 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants