chore: remove hard rollout workaround in test_disk.py for #196 and #227#879
Merged
averevki merged 1 commit intoKuadrant:mainfrom Mar 2, 2026
Merged
Conversation
fabikova
force-pushed
the
fix/remove-workarounds-196
branch
2 times, most recently
from
dc2d7b4 to
c6ed52d
Compare
… and Kuadrant/limitador-operator#227 Signed-off-by: Martina Fabikova <mfabikov@redhat.com>
fabikova
force-pushed
the
fix/remove-workarounds-196
branch
from
c6ed52d to
f400dbc
Compare
azgabur
approved these changes
Mar 2, 2026
Contributor
|
/make kuadrant |
|
Test run has started ( |
averevki
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a legacy rollout workaround and associated comment in the Limitador storage test. These were previously necessary due to a "Multi-Attach error" and reconciliation issues when using disk storage.
Changes
Removed hard=True parameter from limitador.deployment.rollout() in test_durability within test_disk.py.
Updated the test docstring to remove references to bug Kuadrant/limitador-operator#196.
Verification
Created a Limitador instance with storage.disk on the nightly cluster.
Verified that the Limitador CR correctly transitions to Ready: True status (Kuadrant/limitador-operator#227).
Performed a rollout restart and confirmed the new pod reaches Running status without "Multi-Attach" errors (Kuadrant/limitador-operator#196), confirming the new Recreate deployment strategy works as expected.