fix: return bool instead of tuple in HTTPRoute _ready#981
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
📝 WalkthroughWalkthroughHTTPRoute.wait_for_ready readiness predicate now returns a plain boolean from the ChangesReadiness Predicate Return Type
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
emmaaroche
left a comment
There was a problem hiding this comment.
LGTM, thank you for contribution!
Since this changes shared infrastructure (testsuite/gateway/), please wait for a second review before merging per our team guidelines for core code changes.
Description
While working on #980 , I found a bug in
route.py. The_readyfunction inHTTPRoute.wait_for_ready()returns a tuple instead of a bool due to a trailing comma.Changes
Removed the trailing comma and outer parentheses so _ready returns a plain bool.
Verification
No behavioral change for the happy path. Fixes the edge case where
Falseconditions were incorrectly treated as ready.Summary by CodeRabbit