Added feature to filter on main view (frontend popup + merging functionality with backend function)#62
Closed
choksis8168 wants to merge 14 commits intoKubis10:masterfrom
Closed
Added feature to filter on main view (frontend popup + merging functionality with backend function)#62choksis8168 wants to merge 14 commits intoKubis10:masterfrom
choksis8168 wants to merge 14 commits intoKubis10:masterfrom
Conversation
errors in indexing in filter_treeview function
Added feature to show first five messages in statistics popup
Owner
|
Try to resolve conflicts first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a feature to filter on main view. I added a "Filter" button on the side navigation bar which users can press in order to filter each column header by different values which includes entry fields for name and participants and numerical ranges for all count fields. Note that this doesn't include filtering by chat type since this was addressed in tkroening#6. This merges backend functionality with the
filter_treeviewfunction added in tkroening#4. Users can click "Clear filters" in order to get rid of all selections.Fixes # (issue)
#29 (comment)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The filter feature was manually tested.
Result: The data is filtered so only the rows that match the name are selected.
Result: The data is filtered so only rows where the participants has a subset of the participants entered into the entry box are selected.
Result: The data is filtered so only rows where the number of messages is between min and max are selected.
Result: The data is filtered so only rows where the number of messages is between the min and max and the participants has a subset of the participants entered into the entry box are selected.
Result: All selections are removed so all of the rows appear.
Test Configuration:
Checklist: