test: add logger behavior verification for file size warnings

[KubrickCode]

Add integration test to verify logger.warn calls and file skipping behavior when large files are mixed with valid files in a directory

fix #89

[gemini-code-assist]

Summary of Changes

Hello @KubrickCode, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial integration test to validate the system's behavior when encountering oversized files during the file collection process. The test ensures that files exceeding the maximum allowed size are correctly identified and skipped, preventing their inclusion, while simultaneously confirming that other valid files in the same directory are processed as expected. This enhancement improves the robustness of the file handling logic and verifies the intended file skipping behavior.

Highlights

• Integration Test for File Size Warnings: Added a new integration test to src/pkg/push/files.spec.ts to verify that the collectFiles function correctly skips files that exceed the MAX_FILE_SIZE_MB while still collecting valid files from the same directory.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[KubrickCode]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds an integration test to verify the behavior of collectFiles when encountering files that exceed the maximum size limit. The test correctly checks that oversized files are skipped. However, it misses a key part of the intended behavior verification: ensuring that a warning is logged for each skipped file. I've added a suggestion to include this check, which will make the test more robust and fully align with the PR's goal.

[gemini-code-assist]

This test correctly verifies that large files are skipped, but it's missing a key verification mentioned in the pull request description: checking that logger.warn is called. To make the test complete, you should spy on logger.warn and assert that it has been called. I've also updated the test description to reflect this.

You'll need to add the following import at the top of the file:

import { logger } from "../../internal/utils/logger.js";

    it("should skip files exceeding max size, log a warning, and collect valid files", async () => {
      const warnSpy = jest.spyOn(logger, "warn").mockImplementation(() => {});

      await mkdir(join(testDir, "src"), { recursive: true });

      const largeContent = "x".repeat(MAX_FILE_SIZE_MB * 1024 * 1024);
      await writeFile(join(testDir, "src/large.ts"), largeContent);
      await writeFile(join(testDir, "src/small.ts"), "small content");

      const files = await collectFiles("src", testDir);

      // Should only collect the small file, skipping the large one
      expect(files).toHaveLength(1);
      expect(files[0]?.path).toBe("src/small.ts");
      expect(files[0]?.content).toBe("small content");

      // Should log a warning for the skipped file
      expect(warnSpy).toHaveBeenCalledTimes(1);
      expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining("exceeds maximum"));

      warnSpy.mockRestore();
    });

[KubrickCode]

🎉 This PR is included in version 1.0.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀