refactor: utilize Provider type and improve extensibility #98
Conversation
- Remove void provider from getDefaultBranch and getArchiveUrl functions - Implement Provider-based switch logic to prepare for GitLab, Bitbucket support - Add early validation with ValidationError for unsupported providers - Remove TODO comment in providers.ts and add test cases fix #90
Summary of ChangesHello @KubrickCode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the core logic for determining default branches and archive URLs by introducing a provider-based switch mechanism. This change not only improves the system's extensibility, making it easier to add support for new platforms like GitLab and Bitbucket in the future, but also enhances robustness by implementing early validation for unsupported providers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the provider handling logic to be more extensible by using a Provider type and switch statements, which is a great improvement for future support of services like GitLab and Bitbucket. The changes also include adding validation for unsupported providers and updating test cases accordingly. My review focuses on improving adherence to the repository's style guide, specifically regarding function parameter patterns and avoiding code duplication in tests. These suggestions aim to enhance code consistency and maintainability.
## [1.0.5](v1.0.4...v1.0.5) (2025-11-20) ### 🔧 Maintenance * add logger and github-client utilities ([](6196258)), closes [#72](#72) * add logger behavior verification for file size warnings ([](06f82e9)), closes [#89](#89) * add NetworkError and ValidationError classes ([](4e09739)), closes [#71](#71) * apply barrel export pattern and clean up import paths ([](04ce850)), closes [#100](#100) * apply custom error classes to executor.ts ([](8b78d58)), closes [#73](#73) * apply custom error classes to pull/index.ts ([](ccb01b1)), closes [#74](#74) * apply logger utility across entire project ([](0821077)), closes [#72](#72) * decompose baedal function to reduce complexity ([](15db919)), closes [#74](#74) * decompose executePush function to reduce complexity ([](c2404c4)), closes [#73](#73) * enhance CLI option validation in adapter ([](15f325d)), closes [#93](#93) * implement 2-tier release notes structure ([](8c5eaf0)) * implement BaseError and FileSystemError classes (based on ts-custom-error) ([](ef2e9fc)), closes [#68](#68) * improve coverage by 12% with integration tests ([](3912f18)), closes [#75](#75) * Merge branch 'main' into develop/shlee/68 ([](5e1aec2)) * Merge pull request #101 from KubrickCode/develop/shlee/100 ([](abfe334)), closes [#101](#101) * Merge pull request #81 from KubrickCode/develop/shlee/67 ([](ebaed6a)), closes [#81](#81) * Merge pull request #82 from KubrickCode/develop/shlee/68 ([](cf27101)), closes [#82](#82) * Merge pull request #83 from KubrickCode/develop/shlee/69,70 ([](5310670)), closes [#83](#83) * Merge pull request #84 from KubrickCode/develop/shlee/71 ([](961437a)), closes [#84](#84) * Merge pull request #85 from KubrickCode/develop/shlee/72,73 ([](4fe566e)), closes [#85](#85) * Merge pull request #86 from KubrickCode/develop/shlee/74 ([](1623d2c)), closes [#86](#86) * Merge pull request #87 from KubrickCode/develop/shlee/75 ([](ecd9868)), closes [#87](#87) * Merge pull request #96 from KubrickCode/develop/shlee/88 ([](716527b)), closes [#96](#96) * Merge pull request #97 from KubrickCode/develop/shlee/89 ([](8bbd2d2)), closes [#97](#97) * Merge pull request #98 from KubrickCode/develop/shlee/90 ([](c30c5ed)), closes [#98](#98) * Merge pull request #99 from KubrickCode/develop/shlee/92 ([](0e6f4e3)), closes [#99](#99) * Merge remote-tracking branch 'origin/release' ([](3d585f5)) * move pull public types to pkg/pull/types.ts ([](82943f2)) * pnpm link command failing due to missing global environment setup ([](216c118)) * refactor extract module and add path-helpers utilities ([](3c33d1a)), closes [#69](#69) [#70](#70) * remove unused token parameter from parseSource ([](e6dc4a6)), closes [#91](#91) * reorganize internal modules into core/domain/infra/utils structure ([](c3a07d5)) * resolve immutable commit object error in transform function ([](6e1e853)) * restructure folders following NPM guidelines ([](587c956)), closes [#67](#67) * split extractTarball into strategy pattern ([](7edcb25)), closes [#92](#92) * standardize error handling in download and files modules ([](4619732)), closes [#88](#88) * unify Octokit instantiation with github-client utility ([](92ea5fd)), closes [#72](#72) * Update README ([](d64cf7e)) * Update README, CLAUDE ([](2e4d8a9)), closes [#76](#76) * utilize Provider type and improve extensibility ([](f773d1c)), closes [#90](#90)
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fix #90