Skip to content

feat: add topologyspreadconstraints for service#100

Merged
liu-hm19 merged 6 commits intoKusionStack:mainfrom
gshilei:add-topologyspreadconstraints
Nov 21, 2024
Merged

feat: add topologyspreadconstraints for service#100
liu-hm19 merged 6 commits intoKusionStack:mainfrom
gshilei:add-topologyspreadconstraints

Conversation

@gshilei
Copy link
Copy Markdown
Contributor

@gshilei gshilei commented Nov 20, 2024

What type of PR is this?

What this PR does / why we need it:

PR for issue KusionStack/kusion#1303
Please help to have a review. Thanks.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Comment thread modules/service/common.k Outdated
@Yangyang96
Copy link
Copy Markdown

The comments are clear and straightforward, and the code is properly formatted! Thank you for your contribution! @gshilei

Copy link
Copy Markdown
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gshilei gshilei force-pushed the add-topologyspreadconstraints branch from 4723437 to b205227 Compare November 21, 2024 08:05
@liu-hm19 liu-hm19 merged commit e849dcf into KusionStack:main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants