Skip to content

Conversation

@amyXia1994
Copy link
Contributor

@amyXia1994 amyXia1994 commented Jan 5, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

appops/clickhouse-operator/base/base.k

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

This PR is to workaround the kcl lint bug. The sidecar defined in the base.k file will be overridden by that defined in the prod/main.k file and since kcl lint check works based on the result of the config merge phase, the ContainerPort expression is missing in the lint phase, so kcl lint mistakenly reports an error of "unused import" on the import base.pkg.kusion_models.kube.frontend.container.port as cp statement.

The kcl lint bug will be fixed. issue tracked here: todo @He1pa

To avoid blocking the konfig development (blocked here), this PR removes the "unused" code temporarily.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@amyXia1994 amyXia1994 force-pushed the fix/workaround-lint branch from b6ddefc to baa313d Compare January 6, 2023 02:26
@amyXia1994 amyXia1994 requested a review from markliby as a code owner January 10, 2023 02:35
howieyuen
howieyuen previously approved these changes Jan 10, 2023
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyXia1994 amyXia1994 merged commit 2bc8594 into KusionStack:main Jan 10, 2023
@amyXia1994 amyXia1994 deleted the fix/workaround-lint branch January 10, 2023 06:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants