workaround kcl lint problem #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
appops/clickhouse-operator/base/base.k
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR is to workaround the kcl lint bug. The sidecar defined in the
base.kfile will be overridden by that defined in theprod/main.kfile and since kcl lint check works based on the result of the config merge phase, the ContainerPort expression is missing in the lint phase, so kcl lint mistakenly reports an error of "unused import" on theimport base.pkg.kusion_models.kube.frontend.container.port as cpstatement.The kcl lint bug will be fixed. issue tracked here: todo @He1pa
To avoid blocking the konfig development (blocked here), this PR removes the "unused" code temporarily.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.