Skip to content

remove unused variable #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
+20 −24
Merged

remove unused variable #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apps/v1alpha1/operationjob_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const (
const (
ReasonPodNotFound = "PodNotFound"
ReasonContainerNotFound = "ContainerNotFound"
ReasonReplacedByNewPod = "ReplacedByNewPod"
)

// OperationProgress indicates operation progress of pod
Expand Down Expand Up @@ -134,10 +133,10 @@ type OpsStatus struct {

// error indicates the error info of progressing
// +optional
Error *CodeReasonMessage `json:"error,omitempty"`
Error *ErrorReasonMessage `json:"error,omitempty"`
}

type CodeReasonMessage struct {
type ErrorReasonMessage struct {
// A human-readable short word
// +optional
Reason string `json:"reason,omitempty"`
Expand All @@ -147,7 +146,7 @@ type CodeReasonMessage struct {
}

// Error implements error.
func (c *CodeReasonMessage) Error() string {
func (c *ErrorReasonMessage) Error() string {
return fmt.Sprintf("err: reason=%q, message=%q", c.Reason, c.Message)
}

Expand Down
34 changes: 17 additions & 17 deletions apps/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions config/crd/apps/apps.kusionstack.io_operationjobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@ spec:
error:
description: error indicates the error info of progressing
properties:
code:
description: Code is a globally unique identifier
type: string
message:
description: A human-readable message indicating details
about the transition.
Expand Down