Skip to content

Add hostname policy#359

Merged
ColdsteelRail merged 1 commit into
mainfrom
add-hostname-policy
May 16, 2026
Merged

Add hostname policy#359
ColdsteelRail merged 1 commit into
mainfrom
add-hostname-policy

Conversation

@ColdsteelRail
Copy link
Copy Markdown
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.19%. Comparing base (b662d34) to head (47ba335).

Files with missing lines Patch % Lines
pkg/controllers/collaset/collaset_controller.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   46.08%   46.19%   +0.11%     
==========================================
  Files         123      123              
  Lines        7660     7672      +12     
==========================================
+ Hits         3530     3544      +14     
+ Misses       3811     3808       -3     
- Partials      319      320       +1     
Flag Coverage Δ
unittests 46.19% <75.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ColdsteelRail ColdsteelRail force-pushed the add-hostname-policy branch from 317f528 to 1aea72e Compare May 16, 2026 03:18
When NamingStrategy.PodNamingSuffixPolicy is PersistentSequence, pod
names are deterministic before creation, so automatically set
pod.spec.hostname to the pod name. This removes the need for a separate
HostnamePolicy field and makes the behavior implicit.

- Add GetPostCreateFunc to XSetOperation for hostname injection
- Add integration test for auto hostname with PersistentSequence
- Update kube-api to v0.7.5-0.20260512114711-9570d38337c2
- Update kube-xset to v0.0.2-0.20260515171226-5fb80db19c40
- Add GOLANGCI_VERSION to Makefile

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ColdsteelRail ColdsteelRail merged commit 101f952 into main May 16, 2026
13 of 14 checks passed
@ColdsteelRail ColdsteelRail deleted the add-hostname-policy branch May 16, 2026 13:35
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2026
@ColdsteelRail ColdsteelRail review requested due to automatic review settings May 16, 2026 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力

2 participants