Skip to content

Conversation

@howieyuen
Copy link
Collaborator

When kusion apply in preview stage, the previewed table not always the same.

Root Cause

  • after pre-dependent nodes finished, these downEdges are executing in paralyzing, so we cannot ensure the key returned from resource_node.execute() are alway the same.
  • map traversing(node id -> action), it is originally disordered.

Current Fix

  • ignore concurrent execution of peer nodes
  • save node id in sequence, keep order by traversing slice instead of map

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 6c6b059 into main May 18, 2022
@SparkYuan SparkYuan deleted the changestep_order branch May 18, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants