Skip to content

Conversation

@kaysonyu
Copy link
Contributor

@kaysonyu kaysonyu commented Jul 1, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

docs/kusion/3-concepts/3-module/3-app-dev-guide.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@vercel
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kusionstack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 11:09am

@github-actions
Copy link

github-actions bot commented Jul 1, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kaysonyu
Copy link
Contributor Author

kaysonyu commented Jul 1, 2024

I have read the CLA Document and I hereby sign the CLA

@adohe
Copy link
Contributor

adohe commented Jul 2, 2024

@ss-yuki Thanks for contribution, I just leave some comments, ptal

@kaysonyu
Copy link
Contributor Author

kaysonyu commented Jul 2, 2024

@ss-yuki Thanks for contribution, I just leave some comments, ptal

Thank you very much for your reply. I am learning how to contribute on GitHub.

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit 187dd7e into KusionStack:main Jul 2, 2024
@adohe
Copy link
Contributor

adohe commented Jul 2, 2024

@ss-yuki Thanks again ! We sincerely welcome each new contributor, and hope you enjoy~

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants