fix: resolve all blockers for first official v1.0.0 release#11
Conversation
- Add MIT LICENSE file - Update README: license badge (MIT) and license section - Add Version 1.0.0 to CLI, GUI, and Core csproj files - Make InteractiveMenu read version dynamically from assembly metadata - Update System.CommandLine beta4 → beta5 (2.0.0-beta5.25306.1) - Add human-readable release name to release.yml workflow step Agent-Logs-Url: https://github.com/Kvikku/Windows-Security-Manager/sessions/7f2219f0-4a1e-4e60-87c1-f4ee1c012230 Co-authored-by: Kvikku <85877485+Kvikku@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Prepares the repository for the first official v1.0.0 release by adding a public license, switching runtime version display to an assembly-derived value, updating a stale CLI dependency, and improving release naming in the GitHub Actions workflow.
Changes:
- Added MIT
LICENSEand updated README license badge/section. - Added
<Version>1.0.0</Version>to the CLI, Core, and GUI projects; updated the CLI intro screen to display the runtime assembly informational version. - Updated
System.CommandLineto2.0.0-beta5.25306.1and set an explicit GitHub Release name inrelease.yml.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/WindowsSecurityManager/WindowsSecurityManager.csproj | Sets project version to 1.0.0 and updates System.CommandLine package version. |
| src/WindowsSecurityManager/UI/InteractiveMenu.cs | Replaces hardcoded version string with a runtime assembly informational version lookup. |
| src/WindowsSecurityManager.Gui/WindowsSecurityManager.Gui.csproj | Sets GUI project version to 1.0.0. |
| src/WindowsSecurityManager.Core/WindowsSecurityManager.Core.csproj | Sets Core library version to 1.0.0. |
| README.md | Updates license badge and license section to MIT. |
| LICENSE | Adds MIT license text. |
| .github/workflows/release.yml | Sets a human-friendly GitHub Release name including the tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var appVersion = System.Reflection.Assembly | ||
| .GetExecutingAssembly() | ||
| .GetCustomAttribute<System.Reflection.AssemblyInformationalVersionAttribute>() |
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/Kvikku/Windows-Security-Manager/sessions/51625eaa-7485-4029-9054-5ecc518b7976 Co-authored-by: Kvikku <85877485+Kvikku@users.noreply.github.com>
Fixed in |
|
@copilot can you fix the buld error? |
Agent-Logs-Url: https://github.com/Kvikku/Windows-Security-Manager/sessions/46e0e7f3-a65a-488b-a9f0-48ce69ac7b7e Co-authored-by: Kvikku <85877485+Kvikku@users.noreply.github.com>
Fixed in |
Four blockers were preventing a first official release: no public license, hardcoded version string, stale beta dependency, and a bare tag name in the release workflow.
Changes
<Version>1.0.0</Version>to all three.csprojfiles;InteractiveMenu.csnow reads the version at runtime fromAssemblyInformationalVersionAttributeinstead of the hardcodedv2.0.0:2.0.0-beta4.22272.1(2022) →2.0.0-beta5.25306.1; API-compatible with the existingSetHandlerusage, no advisory vulnerabilitiesname: Windows Security Manager ${{ github.ref_name }}to the Create GitHub Release step so the release page rendersWindows Security Manager v1.0.0instead of a bare tagTo cut the release after merging, push a
v1.0.0tag:git tag v1.0.0 && git push origin v1.0.0