fix: use correct operator precedence in URL construction#100
Merged
Kyrela merged 1 commit intoKyrela:mainfrom Mar 22, 2026
Merged
fix: use correct operator precedence in URL construction#100Kyrela merged 1 commit intoKyrela:mainfrom
Kyrela merged 1 commit intoKyrela:mainfrom
Conversation
Owner
|
I'm dumb af, thanks for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When HTTP support was added (d193310), a regression was introduced that caused all HTTPS URLs to return only
httpswithout the rest of the URL:This is caused by Python's operator precedence —
+binds tighter than the ternaryif/else, so:evaluates as:
Since
is_ssldefaults toTruefor all websites,get_repl()always returns just"https".The fix adds parentheses around the ternary expression: