chore: Remove unused dependency (argmin-math) #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently not used, so removing to trim the number of dependencies
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused argmin-math dependency to reduce the number of project dependencies. The main argmin crate remains as a dependency since it's actively used throughout the codebase for optimization functionality.
- Removes
argmin-math = "0.5.0"from dependencies in Cargo.toml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mhovd
changed the title
Contributor
|
Bencher Report| Branch | remove-argmin-math |
| Testbed | rust-moan |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 25.83 s(+2.36%)Baseline: 25.24 s | 26.55 s (97.31%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 10.51 s(+0.32%)Baseline: 10.48 s | 10.68 s (98.41%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 3.49 s(+0.34%)Baseline: 3.47 s | 3.54 s (98.38%) |
Siel
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not used, so removing to trim the number of dependencies