Wrote the Overview, History, Analysis and Value Proposition paragraphs#2
Merged
Conversation
JeremyHugentobler
requested changes
Jun 7, 2024
JeremyHugentobler
left a comment
JeremyHugentobler
left a comment
There was a problem hiding this comment.
Hi,
Thanks you for your work ! It is really well written and the content is intersting. I added some comments where I think changes are needed and would be happy to discuss about it if you do not agree on certain points.
++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I already wrote them on the main before learning that we needed to do PRs so I reverted them on the main and put them on this branch to PR, hence the high number of commits