Draft: Data loading optimizations#44
Closed
PatrickRMiles wants to merge 29 commits intoLBANN:mainfrom
Closed
Conversation
added 11 commits
April 2, 2026 09:42
… batches (user configurable)
…up, maintaining support for old datasets
…ge order to avoid redundant copies
PatrickRMiles
changed the title
…e clipping (LBANN#40) * apply optimizer every batch, not every epoch; unscale gradients before clipping * trainer tweaks --------- Co-authored-by: Patrick Miles <miles30@tioga.llnl.gov>
…n trainer class (LBANN#43) * apply optimizer every batch, not every epoch; unscale gradients before clipping * trainer tweaks * apply optimizer every batch, not every epoch; unscale gradients before clipping * extract warmup to separate method; switch to warming up set number of batches (user configurable) * whitespace; num_workers revert * ruff * make parallelstrategy, spatial_mesh, ddp_placements attrs of trainer; other small tweaks * remove deprecated config attrs * ruff * get device mesh from ps class attr * ruff * missing self. on some ps accesses * Fix imports and missing self.ps * rm legacy warmup_epochs * Move attributes to base class for clarity * remove warmup_epochs -- not useful to keep support for this * call cleanup_or_resume trainer method directly * rm unused vars --------- Co-authored-by: Patrick Miles <miles30@tioga.llnl.gov> Co-authored-by: Michael McKinsey <michaelmckinsey1@gmail.com>
… batches (user configurable)
… other small tweaks
…up, maintaining support for old datasets
…ge order to avoid redundant copies
…trickRMiles/ScaFFold into miles30/dataset_format_v2_loader_perf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support for old datasets
redundant copies
Based on #43