Move to QtPy compatibility#1404
Closed
mrvisscher wants to merge 10 commits intoLCA-ActivityBrowser:mainfrom
Closed
Move to QtPy compatibility#1404mrvisscher wants to merge 10 commits intoLCA-ActivityBrowser:mainfrom
mrvisscher wants to merge 10 commits intoLCA-ActivityBrowser:mainfrom
Conversation
# Conflicts: # activity_browser/ui/menu_bar.py # activity_browser/ui/tables/models/lca_setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a while now we've wanted to move to PySide6. However, because of missing libraries in the Anaconda distribution of that package we were stuck using PySide2. Impending incompatiblity of PySide2 with newer versions of Python and a desire to also publish the AB on PyPI has led us to make an intermediate move using a library called QtPy.
This library serves as an interface between the Activity Browser and any Qt back-end, allowing us to build for PySide2 and PySide6 simultaneously. Users can install a clean Conda version that uses PySide2, but they can also opt to install PySide6 using pip and use that as the backend.
In the feature we hope to move to PySide6 entirely, but as long as that Anaconda distribution is not fully supported, we are going to be offering this intermediate solution.
Checklist
./activity_browser/docs/wikiIf you have write access (otherwise a maintainer will do this for you):
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog.