Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s PostgreSQL driver and SQLAlchemy requirements to align with SQLAlchemy 2 defaults, and bumps the package version accordingly.
Changes:
- Bump
lco-banzaiversion to1.33.1and add a changelog entry. - Replace
psycopg2-binarywithpsycopg[binary]and update SQLAlchemy requirement to>=2. - Update SQLAlchemy ORM imports to the SQLAlchemy 2.x-supported locations.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
uv.lock |
Locks updated dependency set: psycopg v3 (+ psycopg-binary) and SQLAlchemy >=2. |
pyproject.toml |
Runtime dependency updates for SQLAlchemy 2 and psycopg v3; version bump. |
CHANGES.md |
Adds 1.33.1 release note documenting the driver update. |
banzai/dbs.py |
Updates SQLAlchemy import paths for compatibility with SQLAlchemy 2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "pytest>=4.0", | ||
| "pyyaml", | ||
| "psycopg2-binary", | ||
| "psycopg[binary]", |
There was a problem hiding this comment.
After upgrading psycopg to v3 I think you will need to change any postgres connection urls to postgresql+psycopg:// to target the psycopg3 driver.. See https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#module-sqlalchemy.dialects.postgresql.psycopg
sfoale
left a comment
There was a problem hiding this comment.
Not sure this is going to work with the existing postgres connection urls, if I'm reading the documentation right,
No description provided.