Conversation
…c in ImageGrid component
|
If this is referring to downloads to the user's machine, then we need to
add *.tif (*.tiff?) downloads as well.
At some point, we might want to consider giving the user an option to cast
float-32 and -64 back to int-16 since the destination applications are
typically going to be Photoshop and GIMP. Any possible lossless
compression of those images must be what is supported by Photoshop and GIMP.
…On Wed, Jul 30, 2025 at 9:35 PM Lloyd Dakin ***@***.***> wrote:
Adds "Cards" to the image grid that have a couple of things
- target name of the image
- an analysis icon button mdi-eye
- a download button that supports fits and jpg downloads
Works for the Datasession view as well and datalab outputs
Screenshot.2025-07-30.at.2.17.05.PM.png (view on web)
<https://github.com/user-attachments/assets/b6735fe1-6232-42e4-b7c1-0ba46eb44343>
Closes #216 <#216>
------------------------------
You can view, comment on, or merge this pull request online at:
#225
Commit Summary
- 5806639
<5806639>
move imageDownloadMenu to global and add card sheet to grid with action
buttons
- 4f4c8fa
<4f4c8fa>
move imageDownloadMenu to global and add card sheet to grid with action
buttons
- c77e0e4
<c77e0e4>
Merge branch 'feature/grid-cards' of
https://github.com/LCOGT/datalab-ui into feature/grid-cards
- 2e8552c
<2e8552c>
fallback to download jpg if doesn't exist
- c19d2a9
<c19d2a9>
update image-download-menu to handle fallback URLs for data session view
- 8c359b9
<8c359b9>
prevent event propagation on image analysis click
- 79cd078
<79cd078>
refactor: simplify JPG download logic and restructure scaled download
buttons
- 8394c16
<8394c16>
refactor: update props definition and streamline image rendering logic in
ImageGrid component
File Changes
(6 files <https://github.com/LCOGT/datalab-ui/pull/225/files>)
- *M* src/assets/css/ptr-extra.css
<https://github.com/LCOGT/datalab-ui/pull/225/files#diff-3a18b1bae8c7a8d4a9959da1c819d1b6fe0446c8ec8119492a38f04e2ee15221>
(15)
- *M* src/components/DataSession/OperationWizard.vue
<https://github.com/LCOGT/datalab-ui/pull/225/files#diff-5dd8d0b0447c251b5ce2d0ede4d8f582c174b1dcb83d49faed21858a47937a28>
(1)
- *M* src/components/Global/FilterBadge.vue
<https://github.com/LCOGT/datalab-ui/pull/225/files#diff-1f77a4e694517ac2a69f854c4822409d834794268d3459da3fdc2b29a44cf3a0>
(3)
- *R* src/components/Global/ImageDownloadMenu.vue
<https://github.com/LCOGT/datalab-ui/pull/225/files#diff-76317a87fce8f43e1752f6e151767875e096fa44ce47fd5bf779a6b75154a83b>
(56)
- *M* src/components/Global/ImageGrid.vue
<https://github.com/LCOGT/datalab-ui/pull/225/files#diff-c15430f9d762d452fc19d5ca7c1a3ab68980355624cbdc56eee72f3398dd446a>
(114)
- *M* src/views/AnalysisView.vue
<https://github.com/LCOGT/datalab-ui/pull/225/files#diff-4da16cfbd4dc918359d216440d3f18d42c446a011834b8855cb90922e491c10b>
(2)
Patch Links:
- https://github.com/LCOGT/datalab-ui/pull/225.patch
- https://github.com/LCOGT/datalab-ui/pull/225.diff
—
Reply to this email directly, view it on GitHub
<#225>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTZ3MCPKQVACK4AS7OJABT3LE3DFAVCNFSM6AAAAACCYD4JROVHI2DSMVQWIX3LMV43ASLTON2WKOZTGI3TQNJQGQ2TINI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
|
Collaborator
Author
|
You can still download a TIF from the analysis view, I looked into adding it to the card button but it would take some reorganizing that is out of the scope for this story. Reason being, Tifs don't exist from the archive on it's own so I need to make a call to the backend to generate a tif for me to let the user download. I have a mechanism for this when in analysis mode, but due to my inexperience coupled it into that component. Could make it a new story to add tif downloads to the card as well, but that would need a refactor to pull that logic out into its own thing which would be better anyways. TLDR I mistakenly coupled TIF downloads to the analysis view so it would take some more work outside of the scope of this story to implement |
jnation3406
approved these changes
Aug 1, 2025
Contributor
jnation3406
left a comment
jnation3406
left a comment
There was a problem hiding this comment.
Looks good to me, just think maybe there is something we can do for Datalab output images too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "Cards" to the image grid that have a couple of things
mdi-eyefitsandjpgdownloadsWorks for the
Datasessionview as well and datalab outputsCloses #216