Skip to content

quickfix: do not break stoichiometry if 2 species references are present#116

Merged
exaexa merged 2 commits intomasterfrom
mk-stoichiometry-quickfix
Jul 13, 2021
Merged

quickfix: do not break stoichiometry if 2 species references are present#116
exaexa merged 2 commits intomasterfrom
mk-stoichiometry-quickfix

Conversation

@exaexa
Copy link
Copy Markdown
Member

@exaexa exaexa commented Jul 13, 2021

This should be sufficient for now (and doesn't break anyone else's code), we'll redo the whole stoichiometry part later anyway.

closes #115

@exaexa exaexa requested a review from paulflang July 13, 2021 06:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2021

Codecov Report

Merging #116 (e6681aa) into master (70778a8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   94.11%   94.13%   +0.02%     
==========================================
  Files           8        8              
  Lines         272      273       +1     
==========================================
+ Hits          256      257       +1     
  Misses         16       16              
Impacted Files Coverage Δ
src/readsbml.jl 97.29% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70778a8...e6681aa. Read the comment docs.

@exaexa exaexa merged commit ea39152 into master Jul 13, 2021
@exaexa exaexa deleted the mk-stoichiometry-quickfix branch July 13, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stoichiometry extraction fails when species appears on both sides of chemical reaction equation

1 participant