Heatmap - refactoring and improving errors#16
Merged
LCrossman merged 1 commit intoLCrossman:mainfrom Mar 23, 2025
Merged
Conversation
LCrossman
approved these changes
Mar 23, 2025
Owner
LCrossman
left a comment
LCrossman
left a comment
There was a problem hiding this comment.
Thanks for the refactoring, newer layout looks clearer & returning the Result<(), JsValue> via .ok_or(JsValue::from_str("...") is nicely consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES:
The files in the codebase are generally very long and have mixed responsibilities, making them difficult to read. I suggest refactoring these files into into focused, single-responsibility components. I think this refactoring work should be the priority, and should be done prior to adding any further features or improving the error handling.