Fix exit callbacks not firing on Observer unsubscribe#16
Merged
LDGerrits merged 1 commit intoLDGerrits:mainfrom Apr 9, 2026
Merged
Fix exit callbacks not firing on Observer unsubscribe#16LDGerrits merged 1 commit intoLDGerrits:mainfrom
LDGerrits merged 1 commit intoLDGerrits:mainfrom
Conversation
Replaces stale cache lookup with a proper check, like how it's already done with group removals.
LDGerrits
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
Observer:unsubscribe(Group), exit callbacks for entities inside zones aren't called. PR replaces stale cache lookup with a proper check, like how it's already done with group removals.Test (Client)
Test (Server)